DM-15180: Add coordinate covariance #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
force-pushed
the
tickets/DM-15180
branch
from
53d626f
to
e15144c
Compare
cmsaunders
force-pushed
the
tickets/DM-15180
branch
3 times, most recently
from
3dcff7d
to
8ddfabb
Compare
cmsaunders
force-pushed
the
tickets/DM-15180
branch
from
dee0d47
to
db177d1
Compare
isullivan
approved these changes
Sep 9, 2023
python/lsst/pipe/tasks/functors.py
Outdated
| def _func(self, df): | ||
| # Must not modify original column in case that column is used by | ||
| # another functor. | ||
| output = df[self.col] * (180 / np.pi)**2 if self._radians else df[self.col] |
There was a problem hiding this comment.
Minor comment, but please remove the spaces around the * and / operators.
cmsaunders
force-pushed
the
tickets/DM-15180
branch
from
55816a0
to
59eea10
Compare
cmsaunders
force-pushed
the
tickets/DM-15180
branch
from
59eea10
to
c3c6212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.