DM-40525: Fix numpy invalid warnings with numpy 1.24 #827
Conversation
| with np.errstate(invalid="ignore"): | ||
| vals = 255 - png_mapping.map_intensity_to_uint8(image.array).astype(np.uint8) |
There was a problem hiding this comment.
Looking into the astropy code (which I contributed from our afw version), it has exactly this context manager, except it doesn't do the astype(uint8) cast (intentionally, per the docstring). It's unfortunate that we need to wrap it twice like this, but I guess it's fine (since the astropy method can't do the cast, due to how it's used internally).
There was a problem hiding this comment.
Well, the unfortunate part is that the astropy wrap is unnecessary; or at least I couldn't figure out how to get a warning to trigger with just the clip. But maybe I wasn't giving it the "correct" inputs?
There was a problem hiding this comment.
Hmmm... those lines go back to RHL's initial implementation circa 2016, so who knows:
No description provided.