Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-30895: Move AssembleCoaddTask and its children to drp_tasks #829

Merged
merged 8 commits into from Sep 20, 2023
Merged

DM-30895: Move AssembleCoaddTask and its children to drp_tasks #829

merged 8 commits into from Sep 20, 2023

Conversation

arunkannawadi
Copy link
Member

No description provided.

fred3m
fred3m requested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove assembleCoaddTestUtils.py.

Other than that, and also moving assembleChi2Coadd.py this LGTM.

@arunkannawadi
Copy link
Member Author

Sorry, did you mean I should move assembleChi2Coadd.py as well in this ticket?

@fred3m
Copy link
Contributor

fred3m commented Sep 13, 2023

Yes. There aren't any branches in development, so it makes sense to move it now as opposed to making a new ticket just to move one file.

@erykoff
Copy link
Contributor

erykoff commented Sep 13, 2023

Drive-by review here: There need to be stubs here that forward to the new location and raise a deprecation warning if you use the old location. And a ticket to remove those deprecated usages after whichever release we decided was the correct number.

@arunkannawadi
Copy link
Member Author

I thought about that, but it doesn't work in this case, does it? Given that drp_tasks is downstream and is not setup if you setup pipe_tasks, importing drp_tasks here would add a circular dependency. The redirection with a warning works only if you move the code upstream.

That reminds me that I wanted to add this as a note to the dev guide.

@arunkannawadi
Move subBBoxIter to coaddBase as a util function
b17720e
@arunkannawadi
Transfer to drp_tasks at tickets/DM-30895-transfer
985d2e0 
Files transferred:
- python/lsst/pipe/tasks/dcrAssembleCoadd.py
- tests/test_dcrAssembleCoadd.py
@arunkannawadi
Transfer to drp_tasks at tickets/DM-30895-transfer
fe8c6a4 
Files transferred:
- python/lsst/pipe/tasks/assembleCoadd.py
- tests/test_assembleCoadd.py
@arunkannawadi
Transfer to drp_tasks at tickets/DM-30895-transfer
d9ec095 
File(s) transferred:
  - tests/assembleCoaddTestUtils.py ->
    tests/assemble_coadd_test_utils.py
@arunkannawadi
Transfer to drp_tasks at tickets/DM-30895-transfer
c31ebed 
File(s) transferred:
  - python/lsst/pipe/tasks/assembleChi2Coadd.py ->
    python/lsst/drp/tasks/assemble_chi2_coadd.py
@arunkannawadi
Merge branch 'tickets/DM-30895-transfer' into tickets/DM-30895
772d914
@arunkannawadi
Add stubs to allow import from drp_tasks
f06c258
@arunkannawadi
Add a stub for assembleChi2Coadd.py
1cade28
@arunkannawadi
Copy link
Member Author

arunkannawadi commented Sep 19, 2023 •
edited

  • Move assembleCoaddUtils.py
  • Move assembleChi2Coadd.py
  • Add stubs for import redirects

@arunkannawadi arunkannawadi merged commit d68abc7 into main Sep 20, 2023
2 checks passed
@arunkannawadi arunkannawadi deleted the tickets/DM-30895 branch September 20, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred3m fred3m fred3m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arunkannawadi @fred3m @erykoff