DM-41303: Ensure that we skip empty maps that should not be appended. #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Oct 23, 2023
This also reorders the initialization operation to ensure that tract maps are built prior to any filtering of bad inputs.
erykoff
force-pushed
the
tickets/DM-41303
branch
from
ac447c3
to
53c70d7
Compare
laurenam
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes an incomplete fix on DM-37837. Note that this was also fixed upstream in healsparse, so this makes it compatible with older versions, but also skips some unnecessary computations in all cases.