DM-36638: Add snap combination as a subtask at the beginning of CalibrateImageTask #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-36638
branch
from
1de0f9c
to
9f68924
Compare
kherner
approved these changes
Dec 7, 2023
* Improve docstrings * Remove bogus comments * Reorder and cleanup config fields * Refactor logging * Use properties instead of getters
We don't want to do CR repair using the normal algorithm when there are two snaps available. We don't want to mask the DETECTED plane.
Until we know what we want SnapCombine to actually do, remove almost everything that was previously implemented so that the config namespace is clean. We can always pull it out of git history if we want it. * Modernize method/variable names.
* Modernize (snake case, make private) variable/method names. * Use TestDataset to create snap exposures instead of custom function.
parejkoj
force-pushed
the
tickets/DM-36638
branch
from
9f68924
to
2e9afd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.