Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41648: Propagate higher order moments columns to objectTable #871

Merged
merged 2 commits into from Dec 21, 2023

Conversation

arunkannawadi
Copy link
Member

No description provided.

Copy link
Contributor

@jmeyers314 jmeyers314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I'd like to understand why you're removing iPSF_flag before hitting approve though.

@@ -309,10 +309,6 @@ funcs:
functor: Column
args: slot_ShapeRound_xy
dataset: meas
iPSF_flag:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is defined earlier here:

iPSF_flag:
functor: Column
args: slot_PsfShape_flag
dataset: meas

I'm removing the duplicate entry in this commit.

@arunkannawadi arunkannawadi merged commit 4544ed0 into main Dec 21, 2023
2 checks passed
@arunkannawadi arunkannawadi deleted the tickets/DM-41648 branch December 21, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants