DM-41900: Catch Cholesky failures #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Dec 20, 2023
cmsaunders
force-pushed
the
tickets/DM-41900
branch
2 times, most recently
from
e46f3cf
to
7f0d771
Compare
mrawls
approved these changes
Dec 20, 2023
| @@ -378,6 +378,7 @@ def fit(self, dChi2Tol=0.1, maxIter=100): | |||
| Maximum number of fit iterations allowed. The fit should converge in | |||
| ~10 iterations, depending on the value of dChi2Tol, but this | |||
| maximum provides a backup. | |||
| log : TODO | |||
There was a problem hiding this comment.
I think as I typed TODO I subconsciously knew I would forget it....
| fitFailure = True | ||
| if log is not None: |
There was a problem hiding this comment.
Ah so THIS is the canonical way to log inside a function like this? Fascinating. (In what weird situation would log be None??)
There was a problem hiding this comment.
I'm not sure, but it looks like that there are a bunch of other places in the stack where the logger is passed around like this. I made it optional because it's possible we would want to use the line profile fitter outside the context of task, in which case you wouldn't have a logger set up.
cmsaunders
force-pushed
the
tickets/DM-41900
branch
from
7f0d771
to
b24e31d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.