Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42340: Fix some deprecation warnings #875

Merged
merged 2 commits into from
Jan 4, 2024
Merged

DM-42340: Fix some deprecation warnings #875

merged 2 commits into from
Jan 4, 2024

Commits on Jan 4, 2024

  1. Use ConfigDict to configure pydantic dataclass 

    This is the pydantic v2 interface.
    @timj
    timj committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e6dbd61 View commit details
    Browse the repository at this point in the history

  2. Modify directory cleanup to avoid ResourceWarning 

    Deleting the variable does trigger the clean up of the temporary
directory but it also issues a warning:

ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/var/folders/1x/h9lknjv97cx6lw9npp95xkyr0000gn/T/tmpav1qw4d_'>

Replace the tearDown with an explicit cleanup() call. Also ensure
that any errors in clean up do not cause the tests to fail.
    @timj
    timj committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d9cd81d View commit details
    Browse the repository at this point in the history