DM-42324: Make sure bands exist in DCR subfilter registration test. #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shouldn't be possible to register a subfilter that references a band that doesn't exist; this is a variant of DM-40818. *If* one does manage to register such a subfilter, querying for it with a band constraint (as the CLI script does) is ill-defined - should it return no records since the band does not exist? Or should it return the referencing subfilter recoreds anyway? The previous test assumed the latter, but changes to daf_butler on this ticket are changing the behavior to the former. Registering the band (by registering an instrument and hence some physical_filters) first here avoids that ill-defined behavior, and it should make this test continue to work when DM-40818 is done.
TallJimbo
force-pushed
the
tickets/DM-42324
branch
from
0800bd0
to
c02d9d9
Compare
dhirving
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shouldn't be possible to register a subfilter that references a band that doesn't exist; this is a variant of DM-40818.
If one does manage to register such a subfilter, querying for it with a band constraint (as the CLI script does) is ill-defined - should it return no records since the band does not exist? Or should it return the referencing subfilter recoreds anyway? The previous test assumed the latter, but changes to daf_butler on this ticket are changing the behavior to the former. Registering the band (by registering an instrument and hence some physical_filters) first here avoids that ill-defined behavior, and it should make this test continue to work when DM-40818 is done.