DM-42472: Add minimum valid annulus fraction as a configuration parameter in StackBrightStarsTask #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter in StackBrightStarsTas
bazkiaei
changed the title
leeskelvin
reviewed
Jan 16, 2024
| read_stars : `list` of `lsst.pipe.tasks.processBrightStars.BrightStarStamp` | ||
| List of bright star stamps to be stacked. | ||
| """ | ||
| # finding stamps that do not have enough valid pixels in the annulus |
There was a problem hiding this comment.
I would re-word this in the imperative, i.e.:
Find stamps that do not have enough valid pixels in the annulus
leeskelvin
reviewed
Jan 16, 2024
| for stamp in read_stars: | ||
| if stamp.validAnnulusFraction < self.config.minValidAnnulusFraction: | ||
| inValidStamps.append(stamp) | ||
| # removing stamps that do not have enough valid pixels in the annulus |
There was a problem hiding this comment.
Similarly:
Remove stamps that do not have enough valid pixels in the annulus
leeskelvin
reviewed
Jan 16, 2024
| List of bright star stamps to be stacked. | ||
| """ | ||
| # finding stamps that do not have enough valid pixels in the annulus | ||
| inValidStamps = [] |
There was a problem hiding this comment.
This should just be: invalidStamps (i.e., lowercase V)
leeskelvin
reviewed
Jan 16, 2024
| inValidStamps.append(stamp) | ||
| # removing stamps that do not have enough valid pixels in the annulus | ||
| if len(inValidStamps): | ||
| for inValidStamp in inValidStamps: |
There was a problem hiding this comment.
And lowercase V here also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.