DM-42529: Use the accelerated utility functions in CloughTocher2DInterpolatorTask #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that most of the heavy-lifting is done in |
TallJimbo
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Looks good, aside from the linter errors.
👍 to moving this to meas_algorithms. Probably best to make the new module not lifted to package scope in __init__.py, just because we probably should have done that (to reduce unnecessary import-time logic) for most things already in meas_algorithms; better to start late than never.
to meas_algorithms.
arunkannawadi
force-pushed
the
tickets/DM-42529
branch
from
dc35fb7
to
4a732b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.