DM-42663: Use moments based classifier in isolatedStarAssociationTask. #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Feb 21, 2024
Comment on lines
-114
to
+120
| # Something about this test dataset prefers the older fluxRatio here. | ||
| self.config.star_catalog_calculation.plugins['base_ClassificationExtendedness'].fluxRatio = 0.925 | ||
| # Something about this test dataset prefers a larger threshold here. | ||
| self.config.star_selector["science"].unresolved.maximum = 0.2 |
There was a problem hiding this comment.
Did you confirm that this was necessary, or is this just an extrapolation from how the previous value was different from the default?
There was a problem hiding this comment.
Sadly, it is necessary, and presumably for similar reasons.
erykoff
force-pushed
the
tickets/DM-42663
branch
from
6c76662
to
1dd4e80
Compare
arunkannawadi
approved these changes
Feb 21, 2024
TallJimbo
approved these changes
Feb 22, 2024
erykoff
force-pushed
the
tickets/DM-42663
branch
2 times, most recently
from
c6c2519
to
46013a8
Compare
erykoff
force-pushed
the
tickets/DM-42663
branch
from
46013a8
to
333d4e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selection/threshold is updated in meas_algorithms, but we also need to update the transformed column name for the isolated star association task.