DM-40061: Add parquet output to new CalibrateImageTask #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Feb 22, 2024
| @@ -134,6 +141,7 @@ def __init__(self, *, config=None): | |||
| super().__init__(config=config) | |||
| if not config.optional_outputs: | |||
| self.outputs.remove("psf_stars") | |||
| self.outputs.remove("psf_stars_footprints") | |||
There was a problem hiding this comment.
FWIW, you can also say
del self.psf_stars_footprints
if you find that more expressive. This is moderately new so it's not in common use, but I think I find it a bit more intuitive, given that the connections generally appear as attributes.
There was a problem hiding this comment.
Oh, that's nice! Yes, I'll use that.
These should eventually become the default input catalogs for most subsequent tasks.
parejkoj
force-pushed
the
tickets/DM-40061
branch
from
87e21e7
to
f076bb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.