DM-41600: Write task topic page for CalibrateImageTask #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
changed the title
The test should have used halved images, so that the result gave the same source S/N and photo_calib as the single-visit test.
I somehow must have rebased this line out of `run` before I merged! I also was missing a test that it was being applied in run, which I've added here.
These tasks were moved to drp_tasks.
parejkoj
force-pushed
the
tickets/DM-41600
branch
from
31ecda7
to
50ccbcb
Compare
erinleighh
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Everything looks good, the writeup was well structured and readable. All the links worked, too! If you're feeling generous, there's a missing period at the end of a doc string on line 216 of calibrateImage.py but I didn't see any issue with any of the changes you made in this ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also found and fixed a bug: I'd somehow rebased out the use of the code that matched the psf_stars to set
calib_psf*on the main output catalog. In the interest of not having yet another branch to be careful about rebasing, I'm doing the fix here.