DM-42431: Implement a new task to produce shear compatible warps #895
Conversation
arunkannawadi
force-pushed
the
tickets/DM-42431
branch
from
f72dfaf
to
a6fef85
Compare
|
I promise I'll squash the commits into one, or may be two before merging. |
There was a problem hiding this comment.
I've made lots of minor comments about naming and backwards compatibility, and bigger one about (probably pre-existing) concerns with order of operations. But overall this looks good; it's just nailing down the details that remains.
Also, should we consider moving this task to drp_tasks?
|
|
||
| @classmethod | ||
| def _get_bad_mask(cls, exp: ExposureF, badMaskPlanes: Iterable[str]) -> ExposureF: | ||
| """ |
|
| self.config.coaddPsf.makeControl(), | ||
| ) | ||
|
|
||
| final_warp.setPsf(coaddPsf) |
There was a problem hiding this comment.
Based on Miranda's test, we will need to set filter label and photo calib here.
| with self.timer("warp"): | ||
| exposure = self.warper.warpExposure(wcs, exposure, maxBBox=maxBBox, destBBox=destBBox) | ||
| exposure.setPsf(psfWarped) | ||
|
|
There was a problem hiding this comment.
Oh, I didn't mean to remove these lines. Putting them back.
arunkannawadi
force-pushed
the
tickets/DM-42431
branch
2 times, most recently
from
52a92f6
to
5b06ea8
Compare
arunkannawadi
changed the title
arunkannawadi
force-pushed
the
tickets/DM-42431
branch
2 times, most recently
from
90b7353
to
124deb9
Compare
arunkannawadi
force-pushed
the
tickets/DM-42431
branch
from
23f3491
to
0d4a2c3
Compare
No description provided.