DM-43042: Fix indexing bug in _match_psf_stars #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Feb 27, 2024
| matches = list(best.values()) | ||
| ids = np.array([(match0.getId(), match1.getId()) for match0, match1, d in matches]).T | ||
| # We'll use this to construct index arrays into each catalog. | ||
| ids = np.array([(match_psf.getId(), match_stars.getId()) for match_psf, match_stars, d in matches]).T |
There was a problem hiding this comment.
This looks overly complicated, especially since you use ids[0] and ids[1] separately. Could this just be:
psf_ids = matches[0].getId()
star_ids = matches[1].getId()
There was a problem hiding this comment.
Unfortunately, no. matches is a list of tuples, and it's a pain to work with. This has always been a difficulty with the 2014-era matchXy API.
I agree it's complicated, but this is the only way I know of to do this without iterating through the match list twice.
Improve test to catch the bug. Rename variables in the method to make the components more obvious.
parejkoj
force-pushed
the
tickets/DM-43042
branch
from
60b27ca
to
f65bc68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.