DM-42811: Log unexpected measurement exceptions as WARNING #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Mar 18, 2024
| self.assertIn("Image does not have valid aperture correction map", cm.output[0]) | ||
| # Other warnings may also be emitted. | ||
| warnings = '\n'.join(cm.output) | ||
| self.assertIn("Image does not have valid aperture correction map", warnings) |
There was a problem hiding this comment.
I'm surprised to see this particular message in a warning at this stage. Is this because we're trying to continue even in the absence of aperture corrections, and we can only represent that by setting it to None on the Exposure? If not, it's a pipeline configuration error and that should be an exception.
I realize this is preexisting, but we should probably do something about it, even if it's "create a ticket".
There was a problem hiding this comment.
CalibrateTask is a whole mess of "do this when that but this except that catch and log debug" nonsense. I'd rather spend as little time on it as possible, and just focus on CalibrateImageTask from here on.
parejkoj
force-pushed
the
tickets/DM-42811
branch
from
c3bd699
to
15c9f4f
Compare
This may not be the first or only warning on the stack.
parejkoj
force-pushed
the
tickets/DM-42811
branch
from
15c9f4f
to
9b8e58e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.