DM-40441: Rewrite HiPS custom QG builder to inherit from new base class. #913
Conversation
This avoids using deprecated interfaces like Pipeline.toExpandedPipeline while letting the base class handle a lot of details.
| """A custom a `lsst.pipe.base.QuantumGraphBuilder` for running | ||
| `HighResolutionHipsTask` only. | ||
|
|
||
| This is a temporary workaround for incomplete butler query support for |
There was a problem hiding this comment.
Is there a ticket number for the real solution?
There was a problem hiding this comment.
No, and I'm not sure how I want to do it yet; there are a few options but none seem terribly close. Might be best to drop the "temporary" instead.
| @@ -596,24 +606,26 @@ def build_quantum_graph( | |||
| where_terms.append(f"({common_skypix_name} >= cpx{n}a AND {common_skypix_name} <= cpx{n}b)") | |||
| bind[f"cpx{n}a"] = begin | |||
| bind[f"cpx{n}b"] = stop | |||
| if where is None: | |||
| if not self.where: | |||
There was a problem hiding this comment.
I know this is pre-existing but you are always calculating the join of where_terms.
where = " OR ".join(where_terms)
if self.where:
where = f"({self.where}) AND ({where})"might be better?
| hpx_output_ranges = hpx_pixel_ranges.scaled(4**(config.hips_order - hpx_pixelization.level)) | ||
| output_data_ids = [] | ||
| hpx_output_ranges = hpx_pixel_ranges.scaled( | ||
| 4**(task_node.config.hips_order - hpx_pixelization.level) |
There was a problem hiding this comment.
Is there a note anywhere explaining where the 4 comes from? (it turns up in a couple of places).
There was a problem hiding this comment.
It's the number of healpixels at level N+1 in each healpixel at level N. I'll add a comment somewhere when I get a chance.
| """A custom a `lsst.pipe.base.QuantumGraphBuilder` for running | ||
| `HighResolutionHipsTask` only. | ||
|
|
||
| This is a temporary workaround for incomplete butler query support for |
There was a problem hiding this comment.
No, and I'm not sure how I want to do it yet; there are a few options but none seem terribly close. Might be best to drop the "temporary" instead.
| hpx_output_ranges = hpx_pixel_ranges.scaled(4**(config.hips_order - hpx_pixelization.level)) | ||
| output_data_ids = [] | ||
| hpx_output_ranges = hpx_pixel_ranges.scaled( | ||
| 4**(task_node.config.hips_order - hpx_pixelization.level) |
There was a problem hiding this comment.
It's the number of healpixels at level N+1 in each healpixel at level N. I'll add a comment somewhere when I get a chance.
This avoids using deprecated interfaces like
Pipeline.toExpandedPipelinewhile letting the base class handle a lot of details.