DM-39854: drop deprecated connections obsoleted by finalVisitSummary #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were preexisting issues raised in the review of DM-40441, but not addressed there by accident.
fred3m
approved these changes
Apr 10, 2024
Comment on lines
-500
to
-501
| This is a temporary workaround for incomplete butler query support for | ||
| HEALPix dimensions. |
There was a problem hiding this comment.
Is there a ticket or anything that can be added to the docstring to track when this workaround won't be needed, or is the removal of "temporary" an indication that HEALPIX support isn't planned to be implemented in the butler?
There was a problem hiding this comment.
More the latter. There is some support already, but I don't have a near-term plan for extending to the kind of complete support needed for this QG generation problem.
There was a problem hiding this comment.
I agree that pointing the comment at a jira ticket would be nice though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.