Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39841: Remove deprecated doPsfMatch field #915

Merged
merged 3 commits into from Apr 12, 2024
Merged

DM-39841: Remove deprecated doPsfMatch field #915

merged 3 commits into from Apr 12, 2024

Conversation

arunkannawadi
Copy link
Member

No description provided.

@arunkannawadi
Copy link
Member Author

It's scary that Jenkins/unit tests don't catch this. I shouldn't have removed modelPsf field because that's still being used if makePsfMatched is set to True.

@arunkannawadi
Copy link
Member Author

It should be moved to makeWarp.py instead where it may be used if makePsfMatched is set to True.

@arunkannawadi arunkannawadi merged commit 0ddf7d8 into main Apr 12, 2024
2 checks passed
@arunkannawadi arunkannawadi deleted the tickets/DM-39841 branch April 12, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arunkannawadi @erykoff