DM-43771: Disable warping kernel caches and require consistency with PSF warping. #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
approved these changes
Apr 15, 2024
python/lsst/pipe/tasks/makeWarp.py
Outdated
| # configured here in MakeWarpTask is superseded by the one in | ||
| # AssembleCoaddTask. A pipeline contract in the drp_pipe is | ||
| # present to check that. | ||
| raise RuntimeError("Image warping cache size and CoaddPSf warping cache size do not agree.") |
There was a problem hiding this comment.
Raising FieldValidationError would be the right thing to do (that class was implemented specifically for this, AFAIK) but given that RuntimeError is raised above for another check, I wouldn't be strongly opposed to raising it here as well.
There was a problem hiding this comment.
FieldValidationError is a little too specific to errors in individual fields (rather than consistency across multiple fields) to be used here cleanly. But I see that it inherits from ValueError, so that's probably a better built-in to raise than RuntimeError. I'll also fix the one above the same way.
TallJimbo
force-pushed
the
tickets/DM-43771
branch
from
0db7716
to
e410547
Compare
ValueError is the base class for pex.config.FieldValidationError, which doesn't quite fit here because it's focused on single-field problems rather than consistency problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.