DM-43064: Make PSF-matched warp from DirectWarp #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to put the new unit tests in its own file and fix some minor linting errors, but this branch is ready for a review. |
arunkannawadi
commented
May 21, 2024
TallJimbo
approved these changes
May 22, 2024
arunkannawadi
commented
May 22, 2024
arunkannawadi
force-pushed
the
tickets/DM-43064
branch
2 times, most recently
from
0b6fccc
to
e5f2ee3
Compare
See DM-43771 for the motivation.
We make a copy instead of sharing it with test_make_direct_warp.py since we anticipate dropping this test module very soon.
The original size was too small to perform PSF-matching. This appears to be a good balance between the ability of PSF-match while not making the tests too much time consuming.
arunkannawadi
force-pushed
the
tickets/DM-43064
branch
from
3e678b3
to
cf34d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.