Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40743: Clean up build and use cmake #10

Merged
merged 5 commits into from Oct 9, 2023
Merged

DM-40743: Clean up build and use cmake #10

merged 5 commits into from Oct 9, 2023

Conversation

mwittgen
Copy link
Contributor

No description provided.

TallJimbo
TallJimbo approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the fact that GitHub reports conflicts relative to main is a little worrying. I'd be happy to take another look after you rebase, and you should definitely run Jenkins through at least meas_extensions_psfex after that, too.

TallJimbo and others added 5 commits October 9, 2023 08:03
@TallJimbo
Add initial CMake build.
e68fc42 
This forces some things the autotools build is flexible about, and it
doesn't include any install declarations.

But it seems to build and run and produce the same wrong results when
MKL is present.
@TallJimbo
Fix fftw linkage in CMake build.
fbfb411
@TallJimbo
Remove unnecessary files.
39f1faa 
This includes autotools build files and source files we aren't
compiling,
@TallJimbo
Rename lapack_stub symbols and switch implementation to C++.
c1b0064
Fix cmake build and install
7468434
@mwittgen
Copy link
Contributor Author

mwittgen commented Oct 9, 2023

Rebased and resolved conflicts arising from the bug fix merged into main and switching to C++ in this MR.

@mwittgen mwittgen merged commit 7b9623b into main Oct 9, 2023
3 checks passed
@mwittgen mwittgen deleted the tickets/DM-40743 branch October 9, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwittgen @TallJimbo