DM-29853: Update autoconf files #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
reviewed
Apr 23, 2021
| #else | ||
| #define LM_FINITE finite // other than MSVC, ICC, GCC, let's hope this will work |
There was a problem hiding this comment.
Was the whole levmar package updated or is this change manually edited?
finite still works although not C99 compliant
https://godbolt.org/z/ondxhGoxY
There was a problem hiding this comment.
I did this manually because otherwise it wouldn't compile on osx-arm64 with clang11.
There was a problem hiding this comment.
Reasonable fix. I saw this fixed upstream, but changing the package version opens a whole new can of worms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates provide proper support for macOS 11.0 (Big Sur), osx-arm64, and replace deprecated
finitewithisfinite.