DM-33597: Try to add 429 retry to S3 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 86.48% 85.92% -0.56%
==========================================
Files 22 22
Lines 2685 2714 +29
Branches 397 404 +7
==========================================
+ Hits 2322 2332 +10
- Misses 290 304 +14
- Partials 73 78 +5
Continue to review full report at Codecov.
|
|
@ktlim I've reorganized the S3 code a bit to try to make it possible to catch a 429 client error. Does this look reasonable? I haven't been able to trigger a 429 myself so I can't test it and we can't deploy ticket branch containers to the IDF. |
ktlim
reviewed
Mar 23, 2022
Catch the 429 client error and translate it to something that backoff can catch. Some backends also need to catch 404 instead of NoSuchKey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch the 429 client error and translate it to something
that backoff can catch.
Checklist
doc/changes