DM-34610: Disable flake8 N818 for faked exceptions. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 22 22
Lines 2714 2714
Branches 404 404
=======================================
Hits 2332 2332
Misses 304 304
Partials 78 78
Continue to review full report at Codecov.
|
timj
approved these changes
May 23, 2022
python/lsst/resources/gs.py
Outdated
| pass | ||
|
|
||
| class InternalServerError(ClientError): # type: ignore | ||
| class InternalServerError(ClientError): # type: ignore # noqa: N818 |
There was a problem hiding this comment.
This one doesn't need the noqa because it does end in Error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fallout from the change to flake8 4.0 with pep8-naming 0.12.1.
Checklist
doc/changes