DM-35327: Switch to pyproject.toml and add optional dependencies #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything except flake8 can move to pyproject.toml. To avoid confusion with tooling finding a setup.cfg, move the flake8 configuration to the standard .flake8 location.
"pip install -e" does not yet work for setuptools unless a setup.cfg file exists even if that setup.cfg contains no configuration. Restore the file with the flake8 content.
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 86.20% 86.21%
=======================================
Files 22 22
Lines 2726 2727 +1
Branches 542 542
=======================================
+ Hits 2350 2351 +1
Misses 297 297
Partials 79 79
Continue to review full report at Codecov.
|
Without explicit LICENSE in some situations the file is no longer included.
A wheel can now be built from an sdist, which is the default.
mwittgen
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes