Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35347: Add yamllint, user get_lsst_versions #28

Merged
merged 2 commits into from Jul 12, 2022
Merged

Conversation

mwittgen
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #28 (1fcd6fd) into main (1a01190) will not change coverage.
The diff coverage is n/a.

❗ Current head 1fcd6fd differs from pull request most recent head f66101a. Consider uploading reports for the commit f66101a to get more accurate results

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files          22       22           
  Lines        2727     2727           
  Branches      542      542           
=======================================
  Hits         2351     2351           
  Misses        297      297           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a01190...f66101a. Read the comment docs.

@mwittgen mwittgen changed the title DM-3534: Add yamllint, user get_lsst_versions DM-35347: Add yamllint, user get_lsst_versions Jul 11, 2022
@mwittgen mwittgen requested a review from timj July 11, 2022 01:09
@mwittgen
Copy link
Contributor Author

yamllint crates warnings github workflows. Quoting the on keyword silences them.
adrienverge/yamllint#430

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. If you use the yamllint.yaml from daf_butler many of these changes would not be needed.

.github/workflows/mypy.yaml Outdated Show resolved Hide resolved
@timj
Copy link
Member

timj commented Jul 11, 2022

Maybe we should put a >=1.3.0 constraint on the lsst-versions dependency.

@mwittgen mwittgen merged commit fed4e92 into main Jul 12, 2022
@mwittgen mwittgen deleted the tickets/DM-35347 branch July 12, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants