DM-38552: Support non-file root in constructor for relative paths #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 84.47% 85.49% +1.01%
==========================================
Files 27 27
Lines 3665 3633 -32
Branches 767 746 -21
==========================================
+ Hits 3096 3106 +10
+ Misses 441 416 -25
+ Partials 128 111 -17
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Previously we tried to distinguish between someone constructing a ResourcePath with an schemeless absolute path and someone constructing one with forceAbsolute=True and the distinction was mostly confusing to everyone.
eg TYPE_CHECKING blocks.
andy-slac
approved these changes
Apr 5, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the strange behavior where absolute schemeless URIs can sometimes be updated to
fileURIs but not always.Checklist
doc/changes