Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33394: Refactor the tests #5

Merged
merged 11 commits into from
Feb 10, 2022
Merged

DM-33394: Refactor the tests #5

merged 11 commits into from
Feb 10, 2022

Commits on Feb 5, 2022

  1. Configuration menu
    Copy the full SHA
    c3da9dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7084527 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b3c261 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d71b6c6 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Catch client errors in as_local

    Otherwise an internal error happens if the remote resource
    is missing.
    timj committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    2ae529b View commit details
    Browse the repository at this point in the history
  2. Correctly handle temporary_uri.as_local

    Previously as_local would delete a local temporary
    file even if it did not itself create the temporary
    file.
    timj committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    d0ac3d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Clean up file mkdir() exception handling

    Turns out that os.makedirs would already raise
    if a file was there so catch that and make it consistent.
    timj committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    9174e8f View commit details
    Browse the repository at this point in the history
  2. Fix handling of temporary file in file transfer_from

    Now that we correctly return temporary status in as_local
    for local files that were temporary, we need to have a
    more nuanced check for whether linking is allowed.
    timj committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    3285bc9 View commit details
    Browse the repository at this point in the history
  3. Refactor tests

    Now that the package is standalone it makes sense to have generic
    tests that can then be run for each URI scheme. We also want each
    scheme to be tested in a separate test file.
    
    The big test file has been removed.
    
    There are some complications from mypy.
    timj committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    b2775f5 View commit details
    Browse the repository at this point in the history
  4. Add news fragment

    timj committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    86980b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Simplify logic for reading tmpdir envvars

    Co-authored-by: Russ Allbery <eagle@eyrie.org>
    timj and rra committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    9ebb5b0 View commit details
    Browse the repository at this point in the history