Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38599: Fix contents length checking in server-encoded HTTP responses #51

Merged
merged 2 commits into from Apr 10, 2023

Conversation

airnandez
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.03 ⚠️

Comparison is base (1b3121a) 85.49% compared to head (004c49b) 85.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   85.49%   85.47%   -0.03%     
==========================================
  Files          27       27              
  Lines        3731     3732       +1     
  Branches      766      767       +1     
==========================================
  Hits         3190     3190              
  Misses        428      428              
- Partials      113      114       +1     
Impacted Files Coverage Δ
python/lsst/resources/http.py 81.03% <33.33%> (-0.15%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. I don't think the two length variable definitions needed to move but I'm also fine with them in the new location.

@airnandez airnandez merged commit c73dc92 into main Apr 10, 2023
13 of 15 checks passed
@airnandez airnandez deleted the tickets/DM-38599 branch April 10, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants