DM-38492: Move ResourcePathExpression definition to end of file #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to be a real definition rather than relying on a string to specify the ResourcePath entry. Doing it this away allows users to use ResourcePathExpression in an isinstance call.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 85.69% 85.74% +0.04%
==========================================
Files 27 27
Lines 3804 3816 +12
Branches 781 785 +4
==========================================
+ Hits 3260 3272 +12
Misses 426 426
Partials 118 118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to be a real definition rather than relying on a string to specify the ResourcePath entry. Doing it this away allows users to use ResourcePathExpression in an isinstance call.
Checklist
doc/changes