Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38858: Avoid resetting the sessions unnecessary to prevent leaking socket descriptors #56

Merged
merged 1 commit into from Apr 26, 2023

Conversation

airnandez
Copy link
Contributor

@airnandez airnandez commented Apr 25, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@airnandez airnandez changed the title DM-38858: Avoid resetting the sessions unnecessary to prevent leaking socket de… DM-38858: Avoid resetting the sessions unnecessary to prevent leaking socket descriptors Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.10 ⚠️

Comparison is base (51de4dd) 85.84% compared to head (6267d5e) 85.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   85.84%   85.74%   -0.10%     
==========================================
  Files          27       27              
  Lines        3836     3838       +2     
  Branches      789      791       +2     
==========================================
- Hits         3293     3291       -2     
- Misses        426      428       +2     
- Partials      117      119       +2     
Impacted Files Coverage Δ
python/lsst/resources/http.py 80.39% <60.00%> (-0.65%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay. I need to think a bit more how this leaked in a situation where there was no forked subprocess.

@airnandez
Copy link
Contributor Author

I added more details in JIRA to keep a record of this bug.

@airnandez airnandez merged commit 454f83d into main Apr 26, 2023
13 of 15 checks passed
@airnandez airnandez deleted the tickets/DM-38858 branch April 26, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants