DM-39044: Add as_local support for Python resource URIs #57

timj · 2023-05-04T21:15:46Z

Checklist

ran Jenkins
added a release note for user-visible changes to doc/changes

codecov · 2023-05-04T21:20:20Z

Codecov Report

Patch coverage: 82.53% and project coverage change: -0.33 ⚠️

Comparison is base (cfc45f6) 85.89% compared to head (c78f499) 85.57%.

❗ Current head c78f499 differs from pull request most recent head 7c08b6d. Consider uploading reports for the commit 7c08b6d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   85.89%   85.57%   -0.33%     
==========================================
  Files          27       27              
  Lines        3879     3931      +52     
  Branches      800      815      +15     
==========================================
+ Hits         3332     3364      +32     
- Misses        428      443      +15     
- Partials      119      124       +5

Impacted Files	Coverage Δ
python/lsst/resources/packageresource.py	`88.76% <80.76%> (-11.24%)`	⬇️
tests/test_resource.py	`97.14% <90.90%> (-2.86%)`	⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

python/lsst/resources/packageresource.py

Previously the code just looked for a trailing slash. Modify so that a resource is checked using the isdir API.

Previously the code did not take into account that if you ask for a resource in package lsst.not.there a ModuleNotFoundError would be raised. Now catch this error so that the calling code can decide if it cares or not.

timj force-pushed the tickets/DM-39044 branch from 924a6ac to 2529138 Compare May 4, 2023 21:27

Add as_local support for Python resource URIs

7e77b4b

timj force-pushed the tickets/DM-39044 branch from 2529138 to 7e77b4b Compare May 4, 2023 21:28

TallJimbo approved these changes May 5, 2023

View reviewed changes

python/lsst/resources/packageresource.py Outdated Show resolved Hide resolved

python/lsst/resources/packageresource.py Outdated Show resolved Hide resolved

python/lsst/resources/packageresource.py Outdated Show resolved Hide resolved

timj force-pushed the tickets/DM-39044 branch from f27787a to beadcf4 Compare May 5, 2023 20:27

timj added 2 commits May 5, 2023 14:58

Move __all__ to top of file

c779856

Add isdir support to package resources

89e52af

Previously the code just looked for a trailing slash. Modify so that a resource is checked using the isdir API.

timj force-pushed the tickets/DM-39044 branch from c78f499 to 829bba3 Compare May 5, 2023 21:58

timj added 2 commits May 5, 2023 15:30

Refactor the Python resource code to handle import error

7e88a66

Previously the code did not take into account that if you ask for a resource in package lsst.not.there a ModuleNotFoundError would be raised. Now catch this error so that the calling code can decide if it cares or not.

Add news fragment

7c08b6d

timj force-pushed the tickets/DM-39044 branch from 829bba3 to 7c08b6d Compare May 5, 2023 22:30

timj merged commit eaf6fda into main May 17, 2023
15 checks passed

timj deleted the tickets/DM-39044 branch May 17, 2023 20:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DM-39044: Add as_local support for Python resource URIs #57

DM-39044: Add as_local support for Python resource URIs #57

timj commented May 4, 2023 •

edited

codecov bot commented May 4, 2023 •

edited

DM-39044: Add as_local support for Python resource URIs #57

DM-39044: Add as_local support for Python resource URIs #57

Conversation

timj commented May 4, 2023 • edited

Checklist

codecov bot commented May 4, 2023 • edited

Codecov Report

timj commented May 4, 2023 •

edited

codecov bot commented May 4, 2023 •

edited