Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40167: Some code cleanups #61

Merged
merged 18 commits into from Aug 2, 2023
Merged

DM-40167: Some code cleanups #61

merged 18 commits into from Aug 2, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jul 24, 2023 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited

Codecov Report

Patch coverage: 76.38% and project coverage change: +0.25% 🎉

Comparison is base (9349d46) 85.61% compared to head (9dfa54d) 85.86%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   85.61%   85.86%   +0.25%     
==========================================
  Files          27       27              
  Lines        3949     3913      -36     
  Branches      818      801      -17     
==========================================
- Hits         3381     3360      -21     
+ Misses        441      433       -8     
+ Partials      127      120       -7
Files Changed Coverage Δ
python/lsst/resources/gs.py 24.17% <9.09%> (+0.23%) ⬆️
python/lsst/resources/location.py 80.76% <33.33%> (-0.72%) ⬇️
tests/test_http.py 94.89% <50.00%> (+0.19%) ⬆️
...st/resources/_resourceHandles/_s3ResourceHandle.py 81.01% <60.00%> (+0.38%) ⬆️
python/lsst/resources/http.py 80.60% <71.42%> (+0.17%) ⬆️
.../resources/_resourceHandles/_fileResourceHandle.py 78.43% <100.00%> (-0.82%) ⬇️
.../resources/_resourceHandles/_httpResourceHandle.py 73.04% <100.00%> (+0.62%) ⬆️
python/lsst/resources/_resourcePath.py 95.82% <100.00%> (-0.05%) ⬇️
python/lsst/resources/file.py 90.22% <100.00%> (+0.90%) ⬆️
python/lsst/resources/s3.py 88.58% <100.00%> (+0.41%) ⬆️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andy-slac
andy-slac approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of minor comments.

python/lsst/resources/gs.py Show resolved Hide resolved
python/lsst/resources/gs.py Outdated Show resolved Hide resolved
python/lsst/resources/tests.py Outdated Show resolved Hide resolved
timj added 2 commits July 27, 2023 09:48
@timj
Clean up some with statements
b36763a 
Now uses:

with (
    a(),
    b(),
):

rather than

with a(), b(
):
@timj
Clean up some f-string usage
d784eac
@airnandez
Copy link
Contributor

The changes to http.py look good to me. Thanks for these improvements.

@timj timj marked this pull request as ready for review July 31, 2023 19:36
@timj timj merged commit 48fba50 into main Aug 2, 2023
14 of 15 checks passed
@timj timj deleted the tickets/DM-40167 branch August 2, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-slac andy-slac andy-slac approved these changes

@airnandez airnandez airnandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timj @airnandez @andy-slac