Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40573: Ensure checks of non-webDAV endpoints return False instead of raising #64

Merged
merged 1 commit into from Aug 30, 2023

Conversation

airnandez
Copy link
Contributor

@airnandez airnandez commented Aug 30, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (4bb9eea) 85.91% compared to head (60708eb) 85.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   85.91%   85.97%   +0.06%     
==========================================
  Files          27       27              
  Lines        3927     3930       +3     
  Branches      805      805              
==========================================
+ Hits         3374     3379       +5     
+ Misses        433      432       -1     
+ Partials      120      119       -1     
Files Changed Coverage Δ
python/lsst/resources/http.py 81.22% <100.00%> (+0.35%) ⬆️
tests/test_http.py 94.98% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@airnandez airnandez merged commit 9e43544 into main Aug 30, 2023
16 checks passed
@airnandez airnandez deleted the tickets/DM-40573 branch August 30, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants