Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35695: Avoid encoding fragments in schemeless URIs #65

Merged
merged 2 commits into from Sep 2, 2023
Merged

Conversation

timj
Copy link
Member

@timj timj commented Sep 1, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (9e43544) 85.97% compared to head (772d5ab) 86.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   85.97%   86.01%   +0.03%     
==========================================
  Files          27       27              
  Lines        3930     3940      +10     
  Branches      805      806       +1     
==========================================
+ Hits         3379     3389      +10     
  Misses        432      432              
  Partials      119      119              
Files Changed Coverage Δ
python/lsst/resources/_resourcePath.py 95.88% <100.00%> (+0.06%) ⬆️
tests/test_schemeless.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@timj timj merged commit 87a22c7 into main Sep 2, 2023
16 checks passed
@timj timj deleted the tickets/DM-35695 branch September 2, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants