DM-41112: Always make created directories writeable by owner #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 86.03% 86.12% +0.09%
==========================================
Files 27 27
Lines 3959 4029 +70
Branches 812 825 +13
==========================================
+ Hits 3406 3470 +64
- Misses 434 438 +4
- Partials 119 121 +2
☔ View full report in Codecov by Sentry. |
When creating directories, we now modify the filesystem permissions to add the write and execute bits for the current user if they aren't already set. This fixes exceptions caused by filesystem permissions when attempting to create files in read-only directories. This issue was occurring because users had set the global process umask to 0222 in an attempt to force files to be read-only.
Similar to the previous commit, fixed an issue where we could fail to write to a temporary file we had just created if the process is running with a restrictive umask value.
dhirving
force-pushed
the
tickets/DM-41112
branch
from
9164962
to
136460e
Compare
|
The mypy failures are pre-existing and not related to this PR |
ktlim
approved these changes
Oct 12, 2023
A new version of mypy made it an error to use a TypeVar as a return type without something to constrain it in the parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes