DM-41190: Fix resources test_walk failure on CI #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 27 27
Lines 4029 4029
Branches 825 825
=======================================
Hits 3470 3470
Misses 438 438
Partials 121 121
☔ View full report in Codecov by Sentry. |
Fixed an issue where test_walk in test_resource.py would intermittently fail with a "File not found" error when tests are running in parallel. This was occurring because a temporary file created in __pycache__ would be picked up while listing the directory. The is_file() check was returning False because the file no longer existed, so we were incorrectly assuming it was a directory.
dhirving
force-pushed
the
tickets/DM-41190
branch
from
fcdfee7
to
1b8dd94
Compare
ktlim
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes