DM-41879: Implement S3 URL signing #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 86.10% 86.10% -0.01%
==========================================
Files 27 27
Lines 4030 4065 +35
Branches 826 831 +5
==========================================
+ Hits 3470 3500 +30
- Misses 438 446 +8
+ Partials 122 119 -3 ☔ View full report in Codecov by Sentry. |
dhirving
force-pushed
the
tickets/DM-41879
branch
2 times, most recently
from
229593b
to
d657d99
Compare
dhirving
changed the title
dhirving
force-pushed
the
tickets/DM-41879
branch
2 times, most recently
from
9a11f9e
to
800032e
Compare
Added a new function for cleaning up the S3 environment before running tests. This replaces the two existing functions which had some problems: * 'clean_test_environment' wasn't clearing every environment variable that could affect the tests. * 'setAwsEnvCredentials' was hazardous because it could leave real credentials in place by accident, causing real infrastructure to be mutated.
Limit the parent directory creation in HttpResourcePath.write() to WebDAV endpoints only. Presigned S3 URLs do not have any way to check for existence of the parent directory. S3 has no concept of directories and even if it did, you wouldn't be able to do anything about them via a URL signed for the child.
dhirving
force-pushed
the
tickets/DM-41879
branch
from
800032e
to
da6e605
Compare
unittest.TestCase.enterContext() only became available in 3.11
dhirving
force-pushed
the
tickets/DM-41879
branch
from
da6e605
to
b2db37e
Compare
timj
approved these changes
Dec 6, 2023
doc/changes/DM-41879.feature.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Added functions to S3ResourcePath for generating presigned HTTP URLs | |||
There was a problem hiding this comment.
I think you have added a new API to ResourcePath (say what it is) and there is only an implementation for S3.
2 tasks
Tim decided we should have a period of deprecation for these before removing them
dhirving
force-pushed
the
tickets/DM-41879
branch
from
87cc6b1
to
60ba628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes