DM-42190: Fix mypy no-implicit-reexport compatibility #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 86.52% 86.53%
=======================================
Files 27 27
Lines 4201 4202 +1
Branches 850 850
=======================================
+ Hits 3635 3636 +1
Misses 445 445
Partials 121 121 ☔ View full report in Codecov by Sentry. |
SQRE repositories have their mypy configured with `no-implicit-reexport` enabled, which prevents you from using symbols imported by name into a module from another module unless they are listed in __all__. Before this change, mypy would fail with an `attr-defined` error if you tried to `from lsst.resources import ResourcePath`.
dhirving
force-pushed
the
tickets/DM-42190
branch
from
d5a045f
to
9668c19
Compare
timj
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQRE repositories have their mypy configured with
no-implicit-reexportenabled, which prevents you from using symbols imported by name into a module from another module unless they are listed in__all__.Before this change, mypy would fail with an
attr-definederror if you tried tofrom lsst.resources import ResourcePath.Checklist
doc/changes