Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41547: Remove test dependencies from s3 and https deps #80

Merged
merged 1 commit into from Jan 23, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Jan 23, 2024

The s3 and https optional dependency groups included dependencies that are only needed for running tests. This was causing downstream users to pull in unnecessary dependencies. These deps have now been moved to the "test" group.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72166a0) 86.53% compared to head (af918ee) 86.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files          27       27           
  Lines        4202     4202           
  Branches      850      850           
=======================================
  Hits         3636     3636           
  Misses        445      445           
  Partials      121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The s3 and https optional dependency groups included dependencies that are only needed for running tests.  This was causing downstream users to pull in unnecessary dependencies.  These deps have now been moved to the "test" group.
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does raise the problem that if they ask for test they now get the s3 packages regardless. I imagine that's not really a problem because no-one is actually asking for test and having to do a test+s3 seems overkill.

@dhirving dhirving merged commit 651d55e into main Jan 23, 2024
17 checks passed
@dhirving dhirving deleted the tickets/DM-41547 branch January 23, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants