DM-42698: Switch to the moto v5 API

[timj]

Checklist

• ran Jenkins
• added a release note for user-visible changes to doc/changes

[ktlim]

Except I guess I don't approve the test failure :)

[timj]

Yes. You jumped the gun a bit 😄. The failure is a bit odd because it is acting like one batch of writes is being completely ignored by moto. Works fine in v4.

Daf_butler needs fixing as well.

[timj]

I am wondering if this is caused by getmoto/moto#7152

[timj]

The tests are failing because pagination in moto doesn't seem to be paginating. It's only returning the first 1000 results and no second page.

[codecov]

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (bee90fe) 86.84% compared to head (a757480) 86.79%.

Files	Patch %	Lines
.../resources/_resourceHandles/_baseResourceHandle.py	0.00%	0 Missing and 17 partials ⚠️
python/lsst/resources/utils.py	0.00%	0 Missing and 1 partial ⚠️
tests/test_s3.py	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   86.84%   86.79%   -0.05%     
==========================================
  Files          27       27              
  Lines        4248     4232      -16     
  Branches      858      860       +2     
==========================================
- Hits         3689     3673      -16     
+ Misses        438      416      -22     
- Partials      121      143      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[timj]

The moto problem is being fixed in getmoto/moto#7283

[timj]

We could possibly change the constraint to !=5.0.0 since the fix will appear in 5.0.1.