DM-43739: Fix memory leak in HTTPResourcePath #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirving
force-pushed
the
tickets/DM-43739
branch
from
0244a2e
to
1733785
Compare
timj
approved these changes
Apr 8, 2024
| @@ -417,7 +417,7 @@ def root_uri(self) -> ResourcePath: | |||
| uri : `ResourcePath` | |||
| Root URI. | |||
| """ | |||
| return self.replace(path="", forceDirectory=True) | |||
| return self.replace(path="", query="", fragment="", forceDirectory=True) | |||
Fixed an issue where query parameters or fragments in an HTTP URL would cause it to be considered as having a different root URI. This caused a new HTTP session to be created and cached each time an HTTP URL with a different query parameter was accessed. This resulted in a memory leak in datalinker when it was using HTTPResourcePath to access S3 presigned URLs, which always have unique query parameters.
dhirving
force-pushed
the
tickets/DM-43739
branch
from
1733785
to
3f81acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where query parameters or fragments in an HTTP URL would cause it to be considered as having a different root URI. This caused a new HTTP session to be created and cached each time an HTTP URL with a different query parameter was accessed.
This resulted in a memory leak in datalinker when it was using HTTPResourcePath to access S3 presigned URLs, which always have unique query parameters.
Checklist
doc/changes