OPSIM-1162: comcam sv survey prep #76
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhiannonlynne
force-pushed
the
tickets/OPSIM-1162
branch
from
ae99fb4
to
bb60298
Compare
…est for 'close to twilight'. Modify docstring on related 'SunAltLimitBasisFunction'.
…e to work with new fill value.
…onditions objects. Now will use most restrictive of either keyword or conditions values (so default conditions are widely set).
…n_phase_sunset values
…l "accept_obs" kwarg that allows user to specify that ONLY observations with those notes will be counted. (for basis functions/features which work over the whole sky this is important).
…erk, as a function of percent of performance.
…over features or comments.
…vatory_model setup (which is where this information would come from in operations).
…ue that could have been outside the expected limits could return nan over the whole sky, instead of only locations where the rotTelPos limit was exceeded.
rhiannonlynne
force-pushed
the
tickets/OPSIM-1162
branch
from
db11978
to
730f05f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docstrings on basis functions and features to clarify potential uses.
Also add new basis functions, detailers, and filter schedulers needed to simulate comcam SV surveys.