DM-39490: Fix __all__ and remove useless imports #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing __all__ where I could catch them. * replace list->tuple * Move __all__ above imports
These are legacy from python2.
|
It's fine that this doesn't run correctly on the unit tests - we have fixed this on other PRs. |
|
Looks like it won't let me merge without those tests passing: I'm about to disappear for a couple of days, so if someone could merge it for me this time, that would be great. It's rebased to main as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My removal of
builtinsand__future__imports (all of which were holdovers from python2) was mixed-in with my various scripted__all__cleanups, which is why I couldn't rebase flatten all the__all__commits together.