tickets/DM-27208 #18
Merged
tickets/DM-27208 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only part 1 of this process. Part 2 will be to make the tests work from this new location(still in this PR), and part 3 will be a future PR to refactor this file into multiple files in an `scarlet/initialization` directory as follows: * spectrum.py - contains get_best_fit_seds, get_pixel_sed, get_psf_sed from initialization.py * morphology.py - contains `trim_morphology` and will also include some of the functionality from `init_extended_source` and `init_starlet_source` * coadds.py - contains `build_sed_coadd` and `build_initialization_coadd` * initialization.py - contains `init_extended_source`, `init_starlet_source`, `init_multicomponent_source` and all of the init functions needed for the testing (`hasEdgeFlux`, `initAllSources`, `iniSource`) But in order to not break (or conflict with) PR pmelchior#204 this change is being held until a future PR.
Migrate tests
PSF as model
This commit fixes an issue that was created when porting the tests from scarlet_extensions to scarlet. Namely, I didn't want to have to introduce the `git` package as a dependency so I attempted to replicate the code on my own. That did not go so well... So this commit reimplements the git solution that was working.
added 2 commits
October 13, 2020 16:50
Fix bug in branch names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest scarlet