tickets/DM-32436: implement scarlet lite #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix np.float deprecation
init morphology of extended sources with least the model PSF
minor bug fixes
This includes updating the Starlet class, StarletMorphology class, and the denoising function.
This is useful for merging peaks in footprints
…o incldue mask in MonotonicityConstraint
bug fix_data_box
The dimension checks have been changed from asserts to exceptions so that the mismatched input boxes are printed on error to show what the mismatch was.
This commit comtains the bulk of the updates that make scarlet lite useable. This includes utility methods, initialization methods, and updates to the LiteSource, LiteComponent, etc. to make them compatible with the new methods.
Some classes have slightly different APIs in scarlet lite, so this commit re-introduces the scarlet main property and method names to make the API more universal.
@pmelchior noticed that the major difference in runtime between ADAM and FISTA is the iteration over the proximal operators in each iteration of the fit. So changing this to 1 or 2 improves the runtime by factors of several while having little effect on the overall results. It also creates the detection image in `init_all_sources_main` to prevent the user from having to do so.
Implement scarlet lite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.