tickets/DM-34158 #26
Merged
tickets/DM-34158 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
requested changes
Mar 31, 2022
fred3m
force-pushed
the
tickets/DM-34158
branch
2 times, most recently
from
7450904
to
92dd4da
Compare
taranu
approved these changes
Apr 5, 2022
scarlet/lite/component.py
Outdated
| The array of parameters to constrain. | ||
| prox_step: `float` | ||
| A scaling parameter used in some proximal operators, | ||
| but ignored here. |
There was a problem hiding this comment.
Ok, looking at proxmin, I gather operators need to have x and step as the first two args, and can have any number after that? It should probably be a callable class or something then, but in the meantime, it would be useful to make a note here to that effect for a future clueless reader like myself.
| max_prox_iter: `int` | ||
| Maximum number of proximal iterations. | ||
| factor: `int` | ||
| The factor to scale the noise to set the |
There was a problem hiding this comment.
Ok, perhaps worth noting here then (adding a TODO if a ticket already exists).
This commit implements basic parametric models including PSF sources, sersic models, and general models that are parameterized by the radius and optionally elliptical orientation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements basic parametric models including PSF sources, sersic models, and general models that are
parameterized by the radius and optionally elliptical orientation.