DM-41902: Fix real space convolutions for small images #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 38 38
Lines 4730 4736 +6
=======================================
+ Hits 4486 4492 +6
Misses 244 244 ☔ View full report in Codecov by Sentry. |
erykoff
approved these changes
Nov 29, 2023
| @@ -326,7 +326,7 @@ def convolve(self, image: Image, mode: str | None = None, grad: bool = False) -> | |||
| newshape[2] += kernel.image.shape[2] - image.shape[2] | |||
| _image = _pad(_image, newshape) | |||
| result = convolve(_image, kernel.image, self.convolution_bounds) | |||
| result = centered(_image, image.data.shape) | |||
| result = centered(result, image.data.shape) # type: ignore | |||
There was a problem hiding this comment.
It's because convolve returns either an ndarray or Fourier class. I could cast it to an ndarray but I find typing.cast to be clunky and I find it more readable to just ignore those types of mypy errors when I know what the code is doing.
fred3m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.